Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

fix: Uncaught Error when adding files bigger than 1MB #980

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

lidel
Copy link
Contributor

@lidel lidel commented Apr 26, 2019

This switches pull-to-stream to v0.1.1 which includes a fix Uncaught Error: stream.push() after EOF and truly closes #967 in all build pipelines (semver seems to be not enough when yarn lockfile is used)

@lidel lidel requested review from alanshaw and hugomrdias April 26, 2019 13:25
@ghost ghost assigned lidel Apr 26, 2019
@ghost ghost added the in progress label Apr 26, 2019
lidel added a commit to ipfs/ipfs-companion that referenced this pull request Apr 26, 2019
lidel added a commit to ipfs/ipfs-webui that referenced this pull request Apr 29, 2019
This is a temporary fix until
ipfs-inactive/js-ipfs-http-client#980 is merged upstream
This switches pull-to-stream to v0.1.1 which includes
a fix for ipfs-inactive#967

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
@ghost ghost assigned alanshaw Apr 29, 2019
@alanshaw
Copy link
Contributor

@lidel I've rebased for green CI

@alanshaw alanshaw merged commit cc677f0 into ipfs-inactive:master Apr 29, 2019
@ghost ghost removed the in progress label Apr 29, 2019
@lidel lidel deleted the fix/add-with-1mb branch April 29, 2019 14:36
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add with 1MB file triggers Uncaught Error: stream.push() after EOF
3 participants