This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
fix: webpack build #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
fix/webpack-build
branch
from
b1222f8 to
1843d60
Compare
achingbrain
approved these changes
Aug 14, 2020
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the updated in #55 the browser build for this module got broken.
With the
file-typeupdate, we were getting an error from the lack of thefsmodule as described in sindresorhus/file-type#304 The solution was to replace thefile-typeby its browser version in the browser.Other than that, some installed modules need the node
streamandpath, which were added to aegir's webpack config