This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
chore: update to new multiformats #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had to skip a couple of tests as they use the ipfs api directly which hasn't been migrated yet so it doesn't understand the new CID class. They can be unskipped once js-ipfs ships with the new multiformats module, or the circular dependency between this module and js-ipfs is broken. BREAKING CHANGE: pulls in new multiformats modules
achingbrain
force-pushed
the
chore/update-to-new-multiformats
branch
from
eba0237 to
3174b81
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to skip a couple of tests as they use the ipfs api directly which
hasn't been migrated yet so it doesn't understand the new CID class.
They can be unskipped once js-ipfs ships with the new multiformats module,
or the circular dependency between this module and js-ipfs is broken.
BREAKING CHANGE: pulls in new multiformats modules