fix: parse peer id from message correctly #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peer IDs are sent as a buffer containing the utf bytes for `/ipns/` then the bytes that make up the peer id. Our tests were using a buffer that contained the utf bytes for `/ipns/` followed by the utf bytes for the base encoded peer id, which is wrong. I think this only worked previously because the validator passed the bytes to `PeerId.createFromBytes` which passes them to the `cids` `CID` class constructor which is a lot more forgiving in terms of input than the multiformats `CID` class.
vasco-santos
approved these changes
Jul 12, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peer IDs are sent as a buffer containing the utf bytes for
/ipns/then the bytes that make up the peer id.
Our tests were using a buffer that contained the utf bytes for
/ipns/followed by the utf bytes for the base encoded peer id, which is wrong.
I think this only worked previously because the validator passed the
bytes to
PeerId.createFromByteswhich passes them to thecidsCIDclass constructor which is a lot more forgiving in terms of input than
the multiformats
CIDclass.