This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
next Aegir (fix tests in the middle) #53
Merged
+48
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/util.js
Outdated
| @@ -6,6 +6,7 @@ const CID = require('cids') | |||
| const waterfall = require('async/waterfall') | |||
| const setImmediate = require('async/setImmediate') | |||
| const isCircular = require('is-circular') | |||
| const Buffer = require('safe-buffer').Buffer | |||
There was a problem hiding this comment.
I thought we were dropping Node@4 support? if so we do not need to use safe-buffer
There was a problem hiding this comment.
I was thinking about that as I went through adding this. Do we want to remove all of the safe-buffers at once or progressively?
There was a problem hiding this comment.
I think it makes sense to do this together with the upgrade to aegir@12
- remove node@4 from ci
- ensure 6 & 8 are on ci
- remove safe-buffer
There was a problem hiding this comment.
ok :) Could you also create a issue in js-ipfs to describe that "amazing endeavour"?
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.