Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

The word "Optional" appears before every contact name #31

Closed
roblav96 opened this issue Sep 30, 2016 · 4 comments
Closed

The word "Optional" appears before every contact name #31

roblav96 opened this issue Sep 30, 2016 · 4 comments

Comments

@roblav96
Copy link

roblav96 commented Sep 30, 2016

Example

example
http://i.imgur.com/Zb0Bmsx.jpg

Podfile

pod 'EPContactsPicker', :git => 'https://github.com/ipraba/EPContactsPicker'
use_frameworks!
@roblav96 roblav96 changed the title The word "Optional" appears before every contacts name The word "Optional" appears before every contact name Sep 30, 2016
@Sorix
Copy link
Contributor

Sorix commented Sep 30, 2016

I can't reproduce that bug at my environment but I think PR #32 will fix it, I will be very pleased if you can test it and report your results?

pod 'EPContactsPicker', :git => 'https://github.com/Sorix/EPContactsPicker', :branch => 'fix/31'

@roblav96
Copy link
Author

Running the Contacts Picker demo you've supplied this issue does not occur.

I've been installing my pod from the latest 2.0.0 and using use_frameworks! Let me try this PR and see if it helps.

@Sorix
Copy link
Contributor

Sorix commented Sep 30, 2016

Demo I've supplied is equal to my pull request :), if that fixes your problem please use that temporary solution until project's @ipraba will merge it to master branch.

@roblav96
Copy link
Author

@Sorix It's working properly on the demo so no issues there.

My only concern is the migration to Swift 3 as you've dropped the obj-c bridging support.

From 1.0.6

@objc public protocol EPPickerDelegate { // NOTICE THE @objc
    optional    func epContactPicker(_: EPContactsPicker, didContactFetchFailed error: NSError)
    optional    func epContactPicker(_: EPContactsPicker, didCancel error: NSError)
    optional    func epContactPicker(_: EPContactsPicker, didSelectContact contact: EPContact)
    optional    func epContactPicker(_: EPContactsPicker, didSelectMultipleContacts contacts: [EPContact])
}

To 2.0.0

public protocol EPPickerDelegate { // NOTICE THE MISSING @objc
    optional    func epContactPicker(_: EPContactsPicker, didContactFetchFailed error: NSError)
    optional    func epContactPicker(_: EPContactsPicker, didCancel error: NSError)
    optional    func epContactPicker(_: EPContactsPicker, didSelectContact contact: EPContact)
    optional    func epContactPicker(_: EPContactsPicker, didSelectMultipleContacts contacts: [EPContact])
}

Do you have plans to add an Objective-C Bridging Header file to support legacy users?
BuildingCocoaApps/MixandMatch

@ipraba ipraba closed this as completed in #32 Oct 1, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants