Merge pull request #915 from juhasch/fix/dragdrop-ff

Fix Firefox drag&drop
ipython-contrib · Mar 16, 2017 · 3cb81d8 · 3cb81d8
2 parents 7792bae + fe63dad
commit 3cb81d8
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/jupyter_contrib_nbextensions/nbextensions/dragdrop/main.js b/src/jupyter_contrib_nbextensions/nbextensions/dragdrop/main.js
@@ -99,14 +99,14 @@ define([
         var cell = IPython.notebook.get_selected_cell();
         event.preventDefault();
         if(event.stopPropagation) {event.stopPropagation();}
-            if (event.dataTransfer.items != undefined) {
+
+            if (event.dataTransfer.items !== undefined) {
                 /* Chrome here */
                 var items = event.dataTransfer.items;
                 for (var i = 0; i < items.length; i++) {
                     /* data coming from local file system, must be an image to allow dropping*/
-                    if (items[i].kind == 'file' && items[i].type.indexOf('image/') !== -1) {
-
-                        var blob = items[i].getAsFile();
+                    var blob = items[i].getAsFile();
+                    if (items[i].kind === 'file' && blob.type.indexOf('image/') !== -1) {
                         var filename = blob.name;
                         var reader = new FileReader();
                         reader.onload = ( function(evt) {
@@ -115,7 +115,8 @@ define([
                          } );
                         reader.readAsDataURL(blob);
                     } else {
-                        console.log("Unsupported type:", items[i].kind);
+                        console.log("Unsupported type for file:", blob.name);
+
                     }
                 }
             } else {