From abfc773e42a2995cb3a6b1054790af4e7e02ba5c Mon Sep 17 00:00:00 2001
From: Josh Barnes <joshuacookebarnes@gmail.com>
Date: Fri, 6 Oct 2017 04:08:37 +0100
Subject: [PATCH] [toc2] correct toc tree construction

previously, ul could end up inside another ul without intervening li. It's also now slightly clearer what's going on
---
 .../nbextensions/toc2/toc2.js                 | 23 +++++++++----------
 1 file changed, 11 insertions(+), 12 deletions(-)

diff --git a/src/jupyter_contrib_nbextensions/nbextensions/toc2/toc2.js b/src/jupyter_contrib_nbextensions/nbextensions/toc2/toc2.js
index 8dc1c2447..665446368 100644
--- a/src/jupyter_contrib_nbextensions/nbextensions/toc2/toc2.js
+++ b/src/jupyter_contrib_nbextensions/nbextensions/toc2/toc2.js
@@ -599,7 +599,6 @@
 
         var cell_toc_text = " # Table of Contents\n";
         var depth = 1;
-        var li = ul; //yes, initialize li with ul!
         all_headers = $("#notebook").find(":header"); // update all_headers
         var min_lvl = 1 + Number(Boolean(cfg.skip_h1_title)),
             lbl_ary = [];
@@ -644,18 +643,16 @@
             }
 
             // walk down levels
-            for (var elm = li; depth < level; depth++) {
-                var new_ul = $("<ul/>").addClass("toc-item");
-                elm.append(new_ul);
-                elm = ul = new_ul;
+            for (; depth < level; depth++) {
+                var li = ul.children('li:last-child');
+                if (li.length < 1) {
+                    li = $('<li>').appendTo(ul);
+                }
+                ul = $('<ul class="toc-item">').appendTo(li);
             }
             // walk up levels
             for (; depth > level; depth--) {
-                // up twice: the enclosing <ol> and <li> it was inserted in
-                ul = ul.parent();
-                while (!ul.is('ul')) {
-                    ul = ul.parent();
-                }
+                ul = ul.parent().closest('.toc-item');
             }
 
             var toc_mod_id = h.attr('id') + '-' + num_str;
@@ -665,8 +662,10 @@
             $('<a>').addClass('toc-mod-link').attr('id', toc_mod_id).prependTo(h);
 
             // Create toc entry, append <li> tag to the current <ol>.
-            li = $('<li>').append($('<span/>').append(make_link(h, toc_mod_id)));
-            ul.append(li);
+            ul.append(
+                $('<li>').append(
+                    $('<span>').append(
+                        make_link(h, toc_mod_id))));
         });
 
         // update navigation menu