Multiple routines use non-threadsafe cache

[nikhilm]

Did I miss something?

functions/api/server/runner.go

Line 93 in a7a466f

route, ok := s.cacheget(appName, path)

is called from multiple handlers, but is not thread safe https://github.com/iron-io/functions/blob/a7a466f968006a0dc04668b44e4e04da5b942b46/api/server/internal/routecache/lru.go

[ucirello]

Could you please double check? I am pretty confident we've have guarded the LRU cache with mutexes. Refer to

functions/api/server/server.go

Line 133 in 2c56e79

func (s *Server) cacheget(appname, path string) (*models.Route, bool) {

[nikhilm]

Guess you are right. Could use some refactoring to move the mutex into the cache. We already have well tested lrucache in some other code. Not urgent.