Improvements on API error, swagger and status code #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ucirello
suggested changes
Dec 13, 2016
There was a problem hiding this comment.
This looks nice, however I am pretty confident that it is not fixing the proposed bug, or the bug was generated with a very old version of fn.
The reason is that in the issue it states:
{"error":{"message":"Could not create route"}}Whereas, when you look at routes_update you don't see the constant ErrRoutesCreate anywhere.
How did you reproduce the bug before fixing it?
| @@ -194,7 +194,7 @@ func TestRouteUpdate(t *testing.T) { | |||
| {&datastore.Mock{}, "/v1/apps/a/routes/myroute/do", ``, http.StatusBadRequest, models.ErrInvalidJSON}, | |||
| {&datastore.Mock{}, "/v1/apps/a/routes/myroute/do", `{}`, http.StatusBadRequest, models.ErrRoutesMissingNew}, | |||
|
|
|||
| // success | |||
| // successTe | |||
ucirello
reviewed
Dec 13, 2016
| @@ -52,7 +52,13 @@ func (s *Server) handleRouteUpdate(c *gin.Context) { | |||
|
|
|||
| route, err := s.Datastore.UpdateRoute(ctx, wroute.Route) | |||
| if err != nil { | |||
| log.WithError(err).Debug(models.ErrRoutesUpdate) | |||
| if err == models.ErrRoutesNotFound { | |||
There was a problem hiding this comment.
Perhaps:
if err == models.ErrRoutesNotFound {
...
} else if err != nil {
...
}So to avoid if-within-if situation?
ucirello
approved these changes
Dec 13, 2016
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #421