Question: match events + pause

[phated]

Hey @isaacs, I'm reimplementing a bunch of logic we have in glob-stream and I was thinking about using pause and resume inside a Readable stream, which has led me to this question. Is it possible to get multiple match events if you pause immediately inside the listener?

This is what I am thinking about doing:

var globber = new glob.Glob('**/*.js');
globber.on('match', function(filepath) {
  globber.pause();
  // push filepath into stream
});

// globber.resume() whenever read is called

Appreciate any insight you can give.

[isaacs]

Something like this?

// gs.js
var Readable = require('stream').Readable
var util = require('util')
var glob = require('./')

module.exports = GlobStream

util.inherits(GlobStream, Readable)

function GlobStream (pattern, options) {
  Readable.call(this, { objectMode: true })
  this._glob = new glob.Glob(pattern, options)
  this._glob.on('match', function (filename) {
    if (!this.push(filename)) {
      this._glob.pause()
    }
  }.bind(this))
  this._glob.on('end', function () {
    this.push(null)
  }.bind(this))
}

GlobStream.prototype._read = function () {
  this._glob.resume()
}

Usage:

var GS = require('./gs.js')
var gs = new GS('**/*.js')
gs.on('data', function (filename) {
  console.log('%j', filename)
})
gs.on('end', function () {
  console.log('END')
})

[isaacs]

Anyway, yes, you can pause() whenever, and you should get no match events while paused. But if your goal is to push it into a stream, then the stream can handle a few pushes while it's buffering.

[phated]

@isaacs awesome! thanks!