Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update minimist to 1.2.3 #27

Closed
benbucksch opened this issue Jun 2, 2020 · 1 comment
Closed

Update minimist to 1.2.3 #27

benbucksch opened this issue Jun 2, 2020 · 1 comment

Comments

@benbucksch
Copy link

Dependabot warns me about a moderate security problem in my project, because I use a third party module with native code, which uses node-pre-gyp, which uses mkdirp, which uses minimist 0.0.8.

Please update to minimist 1.2.3, even if that means changing callers due to API changes. Even if the warning is spurious: Just the fact that all developers see this warning and need to investigate it costs a lot of work time for everybody.

Here's what dependabot says:

Remediation

Upgrade minimist to version 1.2.3 or later. For example:

minimist@^1.2.3:
version "1.2.3"

Always verify the validity and compatibility of suggestions with your codebase.
Details
CVE-2020-7598
moderate severity
Vulnerable versions: >= 1.0.0, < 1.2.3
Patched version: 1.2.3

minimist before 1.2.2 could be tricked into adding or modifying properties of Object.prototype using a "constructor" or "proto" payload.

@isaacs
Copy link
Owner

isaacs commented Jun 15, 2020

Already fixed 3 months ago c5b97d1

Latest doesn't use minimist at all.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants