Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Valency: update from changed data sources #775

Open
myrix opened this issue May 17, 2022 · 2 comments
Open

Valency: update from changed data sources #775

myrix opened this issue May 17, 2022 · 2 comments
Assignees
Labels
backend bug is related to backend enhancement this label means that resolving the issue would improve some part of the system

Comments

@myrix
Copy link
Contributor

myrix commented May 17, 2022

Users should be able to update existing perspective's valency data from changed parser results / .eaf corpora.

@myrix myrix added enhancement this label means that resolving the issue would improve some part of the system backend bug is related to backend labels May 17, 2022
@myrix myrix self-assigned this May 17, 2022
@myrix
Copy link
Contributor Author

myrix commented Mar 21, 2023

Should also think on how we would go about situations like in #953, when we update the algorithm and should update valency data even when the source data did not change.

@myrix
Copy link
Contributor Author

myrix commented Mar 27, 2023

Based on discussion with J. Normanskaya, two notes on updating:

  1. When the instance source is deleted, we do not show it and do not process it, e.g. in save_valency_data, except when it is approved.

    We may add indication to such approved instances of deleted sources, and in the future we may give users an option to hide instances and/or do not show duplicate instances.

  2. When the instance source is changed, e.g. when parser result is disambiguated or edited, changing noun cases, and an existing instance no longer corresponds to the source, we delete it even if it was approved by a user.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
backend bug is related to backend enhancement this label means that resolving the issue would improve some part of the system
Projects
None yet
Development

No branches or pull requests

1 participant