Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CSS: Isso should not affect other elements on the site #84

Closed
neverpanic opened this issue Apr 22, 2014 · 2 comments
Closed

CSS: Isso should not affect other elements on the site #84

neverpanic opened this issue Apr 22, 2014 · 2 comments

Comments

@neverpanic
Copy link

Including the Isso embed.min.js loads the Isso CSS which might change the layout of the site. Especially hazardous are the lines

* {
  -webkit-box-sizing: border-box;
  -moz-box-sizing: border-box;
  box-sizing: border-box;
}

generated by isso/css/neat/grid/_grid.scss because isso/css/neat/settings/_grid.scss contains $border-box-sizing: true !default;. Isso should not ship global rules that affect all elements in a page, like the * selector does.

Other CSS rules set by Isso that aren't necessarily a good idea are:

a {
  text-decoration: none;
}

and everything not prefixed with "isso", such as .parent-highlight and .postbox.

@posativ
Copy link
Collaborator

posativ commented Apr 24, 2014

I'll change both class names in the next release, thanks for the ticket.

The global CSS statements are indeed unintentional, but won't change for now (patches welcome of course).

@posativ
Copy link
Collaborator

posativ commented May 27, 2014

I renamed .postbox to .isso-postbox just like .isso-comment. All other classes remain as I see no point to prefix them with .isso. Isso should integrate with the page and does not bring it's own style.

@posativ posativ closed this as completed May 27, 2014
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants