Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: respect node:coverage comments #252

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Jun 21, 2024

This respects the node:coverage comments as used by the node:test coverage reporter.

  • node:coverage disable -> c8 ignore start
  • node:coverage enable -> c8 ignore stop
  • node:coverage ignore next -> c8 ignore ignore next
  • node:coverage ignore next N -> c8 ignore ignore next N

This respects the `node:coverage` comments as used by the node:test
coverage reporter.

- `node:coverage disable` -> `c8 ignore start`
- `node:coverage enable` -> `c8 ignore stop`
- `node:coverage ignore next` -> `c8 ignore ignore next`
- `node:coverage ignore next N` -> `c8 ignore ignore next N`
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, thanks!

@SimenB SimenB merged commit 92d593e into master Jun 22, 2024
7 checks passed
@SimenB SimenB deleted the isaacs/respect-node-coverage-comments branch June 22, 2024 08:11
@SimenB
Copy link
Member

SimenB commented Jun 22, 2024

https://github.com/istanbuljs/v8-to-istanbul/releases/tag/v9.3.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants