Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Suggestion: use class selector instead of data attribute selector #2

Open
clairefro opened this issue Feb 7, 2024 · 1 comment
Open

Comments

@clairefro
Copy link

There's a lot of new stuff going on in this lesson with CSS animations etc.

To reduce cognitive load, I suggest using class names to identify the 4 cards in events.html and select them in events.js. That's something students are already familiar with

@michaelwlu
Copy link

Seconding this. Explaining the data-secret attribute and how to select it is overload at this point in the unit.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants