Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Bug] Unused method definitions in Invidious::LogHandler #4791

Closed
syeopite opened this issue Jul 12, 2024 · 1 comment · Fixed by #4812
Closed

[Bug] Unused method definitions in Invidious::LogHandler #4791

syeopite opened this issue Jul 12, 2024 · 1 comment · Fixed by #4812
Labels
bug Something isn't working

Comments

@syeopite
Copy link
Member

I noticed that the following methods in Invidious::LogHandler aren't actually being used whatsoever, neither in Invidious itself nor anywhere in Kemal.

#puts

def puts(message : String)
@io << message << '\n'
@io.flush
end

#set_log_level

def set_log_level(level : String)
@level = LogLevel.parse(level)
end
def set_log_level(level : LogLevel)
@level = level
end

As such these methods can be safely removed.

I'm opening this issue as to make sure these methods aren't being purposelessly kept

@syeopite syeopite added the bug Something isn't working label Jul 12, 2024
@SamantazFox
Copy link
Member

These can safely be removed!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants