You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think this unintentionally trims newlines in the end where it isn't needed. I think your intent is to remove newline somehow added by the code before but it ends up cutting newlines elsewhere.
There is also an &#x type of entities. I am not sure of the following but you could check if the entity is really a genuine one or fake by doing something like
Nice work. I have some suggestions.
html5-dom-document-php/src/HTML5DOMDocument.php
Line 371 in 3eccd3c
I think this unintentionally trims newlines in the end where it isn't needed. I think your intent is to remove newline somehow added by the code before but it ends up cutting newlines elsewhere.
Another observation on this part:
html5-dom-document-php/src/HTML5DOMDocument.php
Lines 159 to 161 in 3eccd3c
There is also an &#x type of entities. I am not sure of the following but you could check if the entity is really a genuine one or fake by doing something like
html_entity_decode( $matches[0], ENT_QUOTES, 'UTF-8' ) === $matches[0] )
with
preg_replace_callback
Maybe not needed.You could also add some random string every time in the "internal" string for security purposes, maybe I am saying something silly.
The text was updated successfully, but these errors were encountered: