Changed database array access to ensure it's always properly setup #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed configure() to directly set $_config
Fixed typo on comment ('mulitple' -> 'multiple')
|
Sorry to bother, but are you planning to merge this in? I have another pull request to send you that depends on this. |
|
Yes, but please remove the direct manipulation of the |
|
Sure, here it is. :) |
ghost
assigned
|
Merged in develop |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves my cached entries problem mentioned on issue #137 and probably also its authors problem. I was able to run the phpunit tests under PHP 5.5 with this fix too (it would throw initialization errors and not run with the master branch).
Details: