Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

What's the usage of the isBot dependency? #4

Open
songkeys opened this issue Oct 7, 2024 · 1 comment
Open

What's the usage of the isBot dependency? #4

songkeys opened this issue Oct 7, 2024 · 1 comment

Comments

@songkeys
Copy link

songkeys commented Oct 7, 2024

I noticed this unused dependency:

"isbot": "^5.1.17",

Is this an oversight, or does it serve a purpose?

@jrestall
Copy link

jrestall commented Oct 8, 2024

isbot is used by react-router's internal default server entrypoint so is needed. I assume it's not a built-in dependency of react-router as the default entrypoint files can be customized and you could remove isbot for example.

https://github.com/remix-run/react-router/blob/e62d585cc4c664d9e58c7342a9e1140a0ad6f8c9/packages/react-router-dev/config/defaults/entry.server.node.tsx#L6

Since we are talking unused dependencies, autoprefixer and postcss are actually unused since the tailwind vite plugin is used.

"autoprefixer": "^10.4.19",
"postcss": "^8.4.40",

[edit] I see there's already a PR to fix this #5 :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants