Added timing information in recorded stroke #75
Conversation
There was a problem hiding this comment.
This looks fantastic, thank you @panglesd for your contribution! I just have one tiny comment, otherwise all LGTM - once addressed I will merge the PR and release this change in Atrament 2.0 (since it does alter the API of the stroke*** events).
| @@ -206,6 +207,7 @@ module.exports = class Atrament extends AtramentEventTarget { | |||
| this.dispatchEvent('strokerecorded', { stroke }); | |||
| } | |||
| this.strokeMemory = []; | |||
| delete (this.strokeTimestamp); | |||
There was a problem hiding this comment.
I'd say the delete here isn't needed, as we can just hold on to the last value and overwrite it when the next stroke begins - or am I missing an edge case?
There was a problem hiding this comment.
Sure, the delete isn't needed! I added it for some consistency: if no stroke has started, no strokeTimestamp is defined. I can remove this line if you prefer!
There was a problem hiding this comment.
that actually sounds reasonable, thank you! will merge this now and release the new version
Sometimes, not only you need to record the stroke, but also the timing of the stroke, such as for instance here.
I added support for this, and updated
README.mdand the demo. Now,stroke.pointscontains an array of object with propertiespoint(the coordinate) andtimethe time from the beginning of the stroke.Anyway, thanks for your great tool, which I use often!