Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

point drawn event #78

Closed
wants to merge 2 commits into from
Closed

Conversation

profispojka
Copy link

Added a pointdrawn event to be able to watch drawing in realtime.

@profispojka profispojka mentioned this pull request May 14, 2022
@profispojka
Copy link
Author

Hi. Is there anything missing from the pull request? Could I somehow help with the merging process?

@profispojka
Copy link
Author

Hi @jakubfiala. When do you think this could be merged?

@MentalGear
Copy link

This is great, thx @profispojka . Since you have knowledge on draw eventsm any chance you could also take a look at #53 ?

@profispojka
Copy link
Author

@MentalGear Well, if this merge request will be merged, I could then have a look.

@profispojka
Copy link
Author

profispojka commented Jan 5, 2023

So, can this be merged? @jakubfiala

@jakubfiala
Copy link
Owner

@profispojka I'm really sorry I have not been responsive in the last year, I let things slip a bit and couldn't focus on maintaining the library. I'm going to review the PR and merge it on Monday, I've planned some time for Atrament maintenance then. Thank you for your patience and perseverance :)

@jakubfiala
Copy link
Owner

@profispojka thank you for the PR! I do want to include this new event, but I think I'd like to implement it slightly differently, so some of the existing code is reused. Will open another PR and tag you in it so you're kept in the loop :) thanks again!

@jakubfiala jakubfiala closed this Jan 9, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants