Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Redis 3.0 has backwards-incompatible ZADD and others #225

Closed
jbaum-cmcrc opened this issue Nov 16, 2018 · 3 comments
Closed

Redis 3.0 has backwards-incompatible ZADD and others #225

jbaum-cmcrc opened this issue Nov 16, 2018 · 3 comments

Comments

@jbaum-cmcrc
Copy link

Redis 3.0 has backwards-incompatible ZADD, which now takes a mapping rather than *args or even length or **kwargs, as well as other backwards-incompatible changes.

See:

@bmerry
Copy link
Collaborator

bmerry commented Nov 16, 2018

Thanks for the heads-up. I will have to figure out what to do with fakeredis, since I'm sure people will still want to use it with code written against redis 2, and I doubt I will have time to maintain two branches (or even when I'll have time to make all the changes for compatibility with redis-py 3).

@jbaum-cmcrc
Copy link
Author

One temporary measure might be to fail in the fakeredis ZADD (and ZINCRBY, MGET, MSET and MSETNX) when the redis-py version is >=3; that will alert users to the problem and avoid the situation where someone upgrades to the latest redis, the tests pass, but the code fails in production.

@bmerry
Copy link
Collaborator

bmerry commented Jan 14, 2019

Fixed in 1.0rc1, by emulating redis at a level below redis-py rather than emulating all the wrapping added by redis-py.

@bmerry bmerry closed this as completed Jan 14, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants