Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Three minor issues #30

Open
suchoss opened this issue Oct 22, 2019 · 0 comments
Open

Three minor issues #30

suchoss opened this issue Oct 22, 2019 · 0 comments

Comments

@suchoss
Copy link
Contributor

suchoss commented Oct 22, 2019

Hello,

I found three messages in Visual Studio saying following:
1) IDE0067 - Disposable object created by 'new Process {' is never disposed
in ProcessEx.cs

var process = new Process {

2) CA1031 - Modify 'RunAsync' to catch a more specific exception type, or rethrow the exception.
in ProcessEx.cs

} catch (InvalidOperationException) { }

3) CA1031 - Modify 'RunAsync' to catch a more specific exception type, or rethrow the exception.
in ProcessEx.cs

catch (Exception)
{
    // best effort to try and get a more accurate start time, but if we fail to access StartTime
    // (for instance, process has already existed), we still have a valid value to use.
}

Does it make sense to fix them?

Thanks

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant