fix(object): Takes into account the range of bytes starting with 0 #755
Conversation
lib/stores/filesystem.js
Outdated
| try { | ||
| await fs.access(bucketPath, fs.constants.F_OK); | ||
| } catch (ex) { | ||
| exists = true; |
There was a problem hiding this comment.
Thanks for refactoring this, I wasn't sure exactly where the Windows tests were going wrong since I replaced fs-extra.
Could you move this to the utils file as ensureDir(path)? You should also check that the exception code is ENOENT and rethrow when it's not. You can also move the mkdir call below directly to this catch block instead of storing a temporary variable.
Hey @kherock , the ranges changes were done in a separate PR: #753 I'll revisit this PR again to refactor a few more things and get back to you. Thanks! |
Codecov Report
@@ Coverage Diff @@
## main #755 +/- ##
==========================================
- Coverage 89.53% 89.49% -0.04%
==========================================
Files 22 22
Lines 1471 1476 +5
==========================================
+ Hits 1317 1321 +4
- Misses 154 155 +1
Continue to review full report at Codecov.
|
kherock
changed the title
|
This PR is related to this issue: #754 |
Fixes errors when trying to re-create directories that already exist.
Uses a helper function to verify for the directory existence first.
Note this PR also includes the fix for
options.start !== undefinedas I've built on top of my previous branch.