You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
i briefly considered adding this in #163 via a new workflow file test-make-assets.yml but it would be slow and a waste of resources to run all these scripts on every commit and merge. ideally, the scripts should only when any of the code they rely on changed. e.g. make_assets/scatter.py would only run if it changed itself or if scatter.py changed. it's possible to check what changed with git diff. of course, the script could break due to changes in other files as well but I think the risk of that is not high enough to rerun the script every time
name: Test asset scriptson:
pull_request:
branches: [main]push:
branches: [main]workflow_dispatch:
jobs:
run:
runs-on: ubuntu-lateststeps:
- name: Check out repositoryuses: actions/checkout@v4
- name: Set up Pythonuses: actions/setup-python@v5with:
python-version: 3.9
- name: Install package and dependenciesrun: pip install -e .
- name: Run all make_assets scripts concurrentlyrun: | scripts=$(find examples/make_assets -name '*.py') exit_code=0 for script in $scripts; do echo "Running $script" python "$script" & done for job in $(jobs -p); do wait $job || let "exit_code+=1" done if [ "$exit_code" != "0" ]; then echo "One or more scripts failed. Please check the logs above for details." exit $exit_code fi
Should include asset maker ipynb into CI tests.
Link to #62.
The text was updated successfully, but these errors were encountered: