-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: defer loading of pretty-error to improve startup time #1789
Conversation
@Knagis Can you fix linting? |
fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement! Thanks for the contribution 🙇
the failures are caused by timeouts in tests. locally the tests passed green in around a minute.. |
@Knagis Looks like we need update some snapshots, can you do it ehre? |
You can see all of them here - https://github.com/jantimon/html-webpack-plugin/actions/runs/4702143575/jobs/8339169287?pr=1789 |
hmm.. you're right
but locally on node 16 all snapshots match |
@Knagis Yeah, it is very strange, do I need to look why it happens (maybe updating them to solve the problem on CI, because we don't have node.js v16 here and it is not critical change)? |
switched to node12, still everything passes..
|
hmm. now running |
So running that modifies dependency:
Why would CI force newest webpack instead of using the one in package.json? Should i perhaps commit this updated package.json together with fresh snapshots? |
ok, so ended up making more changes:
|
Thank you |
Fixes #1788