Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Drop Scala 2.10 support #39

Closed
japgolly opened this issue Nov 23, 2014 · 7 comments
Closed

Drop Scala 2.10 support #39

japgolly opened this issue Nov 23, 2014 · 7 comments

Comments

@japgolly
Copy link
Owner

Master fails due to differences in implicit resolution between Scala 2.11 and 2.10.

Scala's implicit resolution is trouble enough without juggling two sets of rules.

Strongly leaning towards dropping Scala 2.10 support. Can't see any apps in prod originally in 2.10 that need to and can afford to upgrade scalajs-react but can't afford to upgrade Scala.

@ramnivas
Copy link
Contributor

IMO, it is okay to drop Scala 2.10 precisely for the reasons you stated.

@japgolly
Copy link
Owner Author

Thanks @ramnivas. My natural response is 'I agree' but agreeing with you agreeing with me just means I'm agreeing with myself.

@benjaminjackman
Copy link

We are stuck on 2.10 but it's not worth blocking for us.

@japgolly
Copy link
Owner Author

@benjaminjackman Are you stuck on 2.10 and using Scala.JS though? I'd love to hear some more about your situation.

@japgolly
Copy link
Owner Author

Oh btw PR welcome, anyone. I don't have any moral objection to 2.10.

@benjaminjackman
Copy link

@japgolly Yep, stuck at 2.10 and using ScalaJS. I am working on making portions of a large in house financial codebase written in Scala cross compile in ScalaJS. At some point we are going to upgrade to 2.11 however that's going to require quite a bit of QA effort. I opened sourced some of the code here: https://github.com/cgta/open however that's just the tip of the iceberg as far as the codebase is concerned.

Myself and another programmer are still just experimenting with using ScalaJS react so we haven't made more than a couple toy examples to see how it would work with our system.

I did use it on another open source project here is an example:
https://github.com/benjaminjackman/looty/blob/globalview/looty/src/main/scala/looty/views/widgets/Select2Widget.scala

Again just for experimentation so far, nothing that is in production yet.

@japgolly
Copy link
Owner Author

@benjaminjackman Cool, thanks for sharing. I'm gonna drop 2.10 support for 0.6.0+ but if I get a PR or even change my mind later I'll release a build for 2.10 as well. 0.5.x will continue to support 2.10.

@japgolly japgolly changed the title Master broken on Scala 2.10 Drop Scala 2.10 support Nov 27, 2014
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants