Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Path.iterdir() tests assume a particular order #130

Open
barneygale opened this issue Nov 13, 2024 · 0 comments · May be fixed by #131
Open

Path.iterdir() tests assume a particular order #130

barneygale opened this issue Nov 13, 2024 · 0 comments · May be fixed by #131

Comments

@barneygale
Copy link

The tests for zipp.Path.iterdir() make assumptions about the order of the items returned. This isn't part of the iterdir() contract (order is arbitrary) and it makes the tests brittle to legitimate implementation changes.
barneygale added a commit to barneygale/zipp that referenced this issue Nov 13, 2024
@barneygale
Don't rely on Path.iterdir() output order in tests
7260965 
Adjust tests for `zipp.Path.iterdir()` to sort the resulting paths by name.
Previously the tests depended on how `CompleteDirs` inserts synthetic
directory entries, which is very much an implementation detail!

Resolves jaraco#130
@barneygale barneygale linked a pull request Nov 13, 2024 that will close this issue
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't rely on Path.iterdir() output order in tests barneygale/zipp
1 participant
@barneygale