Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Cannot find module 'jquery' #4184

Open
xtuc opened this issue Feb 19, 2018 · 1 comment
Open

Cannot find module 'jquery' #4184

xtuc opened this issue Feb 19, 2018 · 1 comment
Labels
question

Comments

@xtuc
Copy link

xtuc commented Feb 19, 2018

Following the discussion from Rich-Harris/packd#42 (comment).

In https://github.com/jashkenas/backbone/blob/master/backbone.js#L26 jQuery is require'd in a TryCatch Statement which is probably fine on Node but fails to bundle.

I would suggest to add jquery in the dependencies of Backbone, but I understand that's not what you want and I'm not sure why we should do.
@xtuc xtuc mentioned this issue Feb 19, 2018
Open
@jgonggrijp
Copy link
Collaborator

@xtuc Perhaps jQuery could be made a peer dependency. Would that help?

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xtuc @jgonggrijp