Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Manually following process URL results in a crash #414

Open
Goury opened this issue Jul 6, 2024 · 2 comments
Open

Manually following process URL results in a crash #414

Goury opened this issue Jul 6, 2024 · 2 comments

Comments

@Goury
Copy link

Goury commented Jul 6, 2024

Flow:

  1. Pay for something
  2. Be redirected to schema://domain/urlspace/process/some-long-uuid-string/?paymentId=PAYID-CAPSANDALSONUMBERS1111&token=EC-SOMEMORECAPS&PayerID=AFEWMORECAPS
  3. Be redirected to the successful view
  4. Manually visit URL from 2 for no particular reason
  5. Crash

Expectation:
Not crash but just a 400, because the server had done nothing wrong and just visiting a link one found in ones browser console shouldn't flood admin email with crash reports.

Crash happens at payments/paypal/__init__.py, line 270, in execute_payment

Please fix

@Goury
Copy link
Author

Goury commented Jul 6, 2024

Also FTFY

Not sure if my solution is correct or good, but it works in my case

@WhyNotHugo
Copy link
Member

The provider code should check that the payment is not yet paid before calling execute_payment.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants