Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update type comments to type annotations #568

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

terencehonles
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #568 (257623f) into master (7a2a377) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #568   +/-   ##
======================================
  Coverage    57.7%   57.7%           
======================================
  Files          39      39           
  Lines        2497    2497           
  Branches       63      63           
======================================
  Hits         1440    1440           
  Misses       1049    1049           
  Partials        8       8           
Flag Coverage Δ
mypy 33.8% <50.0%> (ø)
tests 83.3% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
django_redis/client/default.py 90.4% <100.0%> (ø)
django_redis/hash_ring.py 100.0% <100.0%> (ø)
django_redis/pool.py 77.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a2a377...257623f. Read the comment docs.

@WisdomPill
Copy link
Member

Why move to type comments? We are already supporting 3.6+ so it should work on all supported python versions

@terencehonles
Copy link
Contributor Author

Why move to type comments? We are already supporting 3.6+ so it should work on all supported python versions

This removes type comments, because it is supported in 3.6+. The type comments are the older syntax.

@WisdomPill
Copy link
Member

I guess I am stupid, or it's just monday morning

@WisdomPill WisdomPill merged commit 9cd2bbe into jazzband:master Nov 8, 2021
@terencehonles terencehonles deleted the update-type-comments branch November 8, 2021 13:18
@terencehonles
Copy link
Contributor Author

I guess I am stupid, or it's just monday morning

Haha, no prob. Maybe not enough coffee yet? ☕

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants