Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

enable constraints on parameter ranges #32

Closed
jbloom opened this issue Mar 25, 2024 · 1 comment · Fixed by #35
Closed

enable constraints on parameter ranges #32

jbloom opened this issue Mar 25, 2024 · 1 comment · Fixed by #35
Assignees

Comments

@jbloom
Copy link
Member

jbloom commented Mar 25, 2024

Enable setting constraints on parameters (eg, top and slope) that are reasonable ranges rather than fixed values.

This is now feasible with neutcurve 2.0.0 (see this issue).

Probably in general we want to constrain the top to something in the range of 0.7 or 0.8 to 1, and we probably want to constrain the slope to some reasonable range that is not step-like step or very shallow.

In particular, this should help deal with curves that are always or never neutralized, as well as ones with plateaus less than one.

This needs to be implemented into the pipeline.

@jbloom jbloom self-assigned this Mar 25, 2024
@jbloom
Copy link
Member Author

jbloom commented Mar 26, 2024

#34 updates neutcurve, still need to put range constraints into pipeline.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant