Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Disable automated merge of PR after successful PR build to enable more robust code reviews #78

Open
bfitzpat opened this issue Jan 7, 2019 · 0 comments
Labels
Milestone

Comments

@bfitzpat
Copy link
Contributor

bfitzpat commented Jan 7, 2019

We encountered a small hiccup when dealing with camel-tooling/generator-camel-project#38. As soon as the PR was marked "ok to test" and built successfully without errors, another automated process swooped in and merged the PR though a second review pass was in flight and two additional comments were noted for possible fixes to the code introduced.

Instead of an automated process, we might recommend making the merge a manual one? Or at the very least bumping up the time between a successful PR build and the automated merge (perhaps 24 hours?).

@tdiesler tdiesler added the task label Jan 30, 2019
@tdiesler tdiesler added this to the 0.9.0 milestone Jan 30, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants