Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Input type="number" arrows overflow off the input #164

Open
juanigaray opened this issue Mar 29, 2023 · 6 comments
Open

Input type="number" arrows overflow off the input #164

juanigaray opened this issue Mar 29, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@juanigaray
Copy link
Collaborator

juanigaray commented Mar 29, 2023 •
edited
Loading

In this deploy, it looks like this:

image

Whereas on main it looks like this

image
@juanigaray juanigaray added the bug Something isn't working label Sep 20, 2023
@juanigaray
Copy link
Collaborator Author

juanigaray commented Sep 21, 2023 •
edited
Loading

main is "bad", 9c190be is good. Bisecting... (edit: none of those commits was good)

@juanigaray
Copy link
Collaborator Author

juanigaray commented Sep 21, 2023 •
edited
Loading

The first bad commit has my name on it ( 735b3c6 )

image

@juanigaray
Copy link
Collaborator Author

juanigaray commented Sep 22, 2023 •
edited
Loading

No, wait! There aren't any actual good commits in the main branch. Which is very weird. But the results of git blame are invalid.

@juanigaray
Copy link
Collaborator Author

Nothing interesting there. But maybe the implementation of the border changed.

@juanigaray
Copy link
Collaborator Author

Oops! The Good commit was from a PR I closed!
#154

@juanigaray juanigaray changed the title Input type="number" arrows have started overflowing off the input Input type="number" arrows overflow off the input Sep 25, 2023
@juanigaray
Copy link
Collaborator Author

MWUE has Spin Boxes which illustrate how these arrows should look. See p. 184, figure 8.32

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@juanigaray