Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Python 3.13 issue #504

Open
blopker opened this issue Dec 22, 2024 · 3 comments · May be fixed by #505
Open

Python 3.13 issue #504

blopker opened this issue Dec 22, 2024 · 3 comments · May be fixed by #505

Comments

@blopker
Copy link

blopker commented Dec 22, 2024

Heyya, I'm trying to update my site to Python 3.13.1 from 3.12 and the mrml Python package is giving me an error on install:

            "__Py_FalseStruct", referenced from:
                pyo3_ffi::boolobject::Py_False::h6e9f567c960b65c2 in mrml.6n2q40yqp9ohjfvdd900z9xpa.rcgu.o
            "__Py_NoneStruct", referenced from:
                pyo3_ffi::object::Py_None::h859c5a506aff8790 in mrml.33p6zkgdavws1digwyigb597b.rcgu.o
                pyo3_ffi::object::Py_None::hed4c9bb7100ba418 in libpyo3-074370a080eda9c5.rlib[8](pyo3-074370a080eda9c5.pyo3.c60c8efc02a4e87-cgu.05.rcgu.o)
            "__Py_NotImplementedStruct", referenced from:
                pyo3_ffi::object::Py_NotImplemented::h8bd06342b95028c5 in mrml.33p6zkgdavws1digwyigb597b.rcgu.o
            "__Py_TrueStruct", referenced from:
                pyo3_ffi::boolobject::Py_True::h30b83a93710f16f2 in mrml.6n2q40yqp9ohjfvdd900z9xpa.rcgu.o
                pyo3_ffi::boolobject::Py_True::h32f7809a6a402da3 in libpyo3-074370a080eda9c5.rlib[15](pyo3-074370a080eda9c5.pyo3.c60c8efc02a4e87-cgu.12.rcgu.o)
          ld: symbol(s) not found for architecture arm64
          clang: error: linker command failed with exit code 1 (use -v to see invocation)


warning: `mrml-python` (lib) generated 5 warnings
error: could not compile `mrml-python` (lib) due to 1 previous error; 5 warnings emitted

Maybe py03 needs to be updated?

Thank you!
@blopker
Copy link
Author

blopker commented Dec 22, 2024

This is on an M1 Mac, with the latest OS.

@blopker
Copy link
Author

blopker commented Dec 23, 2024

Here's a minimal Dockerfile reproduction:

FROM python:3.13-slim-bookworm

RUN pip install mrml

Run docker build .
Output:

 > [2/2] RUN pip install mrml:
1.366 Collecting mrml
1.477   Downloading mrml-0.1.15.tar.gz (131 kB)
1.580   Installing build dependencies: started
2.921   Installing build dependencies: finished with status 'done'
2.922   Getting requirements to build wheel: started
2.944   Getting requirements to build wheel: finished with status 'done'
2.944   Preparing metadata (pyproject.toml): started
2.966   Preparing metadata (pyproject.toml): finished with status 'error'
2.968   error: subprocess-exited-with-error
2.968
2.968   × Preparing metadata (pyproject.toml) did not run successfully.
2.968   │ exit code: 1
2.968   ╰─> [6 lines of output]
2.968
2.968       Cargo, the Rust package manager, is not installed or is not on PATH.
2.968       This package requires Rust and Cargo to compile extensions. Install it through
2.968       the system's package manager or via https://rustup.rs/
2.968
2.968       Checking for Rust toolchain....
2.968       [end of output]
2.968
2.968   note: This error originates from a subprocess, and is likely not a problem with pip.
3.137 error: metadata-generation-failed
3.137
3.137 × Encountered error while generating package metadata.
3.137 ╰─> See above for output.
3.137
3.137 note: This is an issue with the package mentioned above, not pip.
3.137 hint: See above for details.

@blopker blopker linked a pull request Dec 23, 2024 that will close this issue
Open
@mgax mgax mentioned this issue Jan 5, 2025
Open
@blopker
Copy link
Author

blopker commented Jan 29, 2025

Is there anything I can do to help with this issue? Python is on 3.13.1 now, a lot of projects tend to do their minor updates after the first patch version is released.

I think not doing the nogil work is fine for now since there's not many benefits now and I don't think many projects use it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add support for 3.13 with no GIL blopker/mrml
1 participant
@blopker