Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

vertical column autoMerge needed for HTML mode #348

Closed
sceneryback opened this issue Jan 2, 2025 · 4 comments
Closed

vertical column autoMerge needed for HTML mode #348

sceneryback opened this issue Jan 2, 2025 · 4 comments
Labels
enhancement New feature or request

Comments

@sceneryback
Copy link

Is your feature request related to a problem? Please describe.
Currently vertical autoMerge works well with console table mode, but doesn't work with html mode
html mode:
WeChatWorkScreenshot_a4c6357f-3772-4b3d-8fe3-0ee2559c276b
normal mode:
WeChatWorkScreenshot_f1d2f2a2-f9d8-46c5-9957-bb0e6f2eac0f

Describe the solution you'd like
Need this for html mode, any workaround?

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@jedib0t
Copy link
Owner

jedib0t commented Jan 2, 2025

Hey @sceneryback ... vertical merge is not supported in modes other than the console table: https://github.com/jedib0t/go-pretty/blob/main/table/config.go#L25-L34 - as of now, I don't have plans to support it.

@jedib0t jedib0t added the enhancement New feature or request label Jan 3, 2025
@jedib0t
Copy link
Owner

jedib0t commented Jan 4, 2025

Hey @sceneryback, I supported vertical merging in HTML rendering with a commit in the branch table-vmerge-html - can you test it out and let me know if it works as you want? I'm sure I've missed some cases in my testing.

Please note that row and column auto-merge applied together is not supported, and row-auto-merge takes precedence.

@jedib0t
Copy link
Owner

jedib0t commented Feb 6, 2025

Hey @sceneryback ... ping.

@jedib0t jedib0t closed this as completed in b14745c Mar 1, 2025
@jedib0t
Copy link
Owner

jedib0t commented Mar 1, 2025

Fix is available in https://github.com/jedib0t/go-pretty/releases/tag/v6.6.7 - please let me know if you notice any bugs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants