Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Figure out a way to retain python2 compatibility while modularizing cqlsh #13

Closed
jeffwidman opened this issue Jan 21, 2022 · 3 comments · Fixed by #16 or #19
Closed

Figure out a way to retain python2 compatibility while modularizing cqlsh #13

jeffwidman opened this issue Jan 21, 2022 · 3 comments · Fixed by #16 or #19

Comments

@jeffwidman
Copy link
Owner

The changes in #7 are great, but break under py2: #11

I like the changes in #7 and don't want to revert them, so see if there's a straightforward way to tweak it to make it compatible with py2.

@jeffwidman jeffwidman changed the title Figure out a way to retain python2 compatibility with the changes in Figure out a way to retain python2 compatibility while modularizing cqlsh Jan 21, 2022
@bschoening
Copy link
Collaborator

FYI, Cassandra 4.1 scheduled for April 2022 release will remove python 2.7 compatibility.

@jeffwidman
Copy link
Owner Author

Sounds like an easy way to deal with this.

We'll just need to be sure the Classifiers and python_requires sections are updated appropriately before cutting that release.

(and also pull in the 4.1 version of the cqlsh code)

@jeffwidman
Copy link
Owner Author

I'm going to close this... even though it's not present here, cassandra trunk already removed Python 2, which will arrive with cassandra 4.1. I opened a draft PR so once it's ready/merged, this will be a non-issue. In the meantime, our master branch here is still broken under Python 2, and that's just fine since the actual release on PyPI is still python 2 compatible.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
2 participants