Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Avoid mixed-content warning on https websites #295

Closed
6 tasks
first-timers bot opened this issue May 22, 2018 · 3 comments
Closed
6 tasks

Avoid mixed-content warning on https websites #295

first-timers bot opened this issue May 22, 2018 · 3 comments

Comments

@first-timers
Copy link

first-timers bot commented May 22, 2018

πŸ†•πŸ₯☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you πŸ’

About First Timers Only.

πŸ€” What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

πŸ“‹ Step by Step

  • πŸ™‹ Claim this issue: Comment below.

    Once claimed we add you as contributor to this repository.

  • πŸ‘Œ Accept our invitation to this repository. Once accepted, assign yourself to this issue

  • πŸ“ Update the file lib/jekyll-seo-tag/json_ld_drop.rb in the jekyll-seo-tag repository (press the little pen Icon) and edit the line as shown below.

@@ -28,7 +28,7 @@ def initialize(page_drop)
 
       def fallback_data
         {
-          "@context" => "http://schema.org",
+          "@context" => "https://schema.org",
         }
       end
 
  • πŸ’Ύ Commit your changes

  • πŸ”€ Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can edit files directly in your browser

  • 🏁 Done Ask in comments for a review :)

πŸ€”β“ Questions

Leave a comment below!

This issue was created by First-Timers-Bot.
Fix #294

@DirtyF DirtyF changed the title Avoid mixed-content warning on https websites Fix #294 Avoid mixed-content warning on https websites May 22, 2018
@alokpant
Copy link
Contributor

hey, can i take this issue?

@alokpant
Copy link
Contributor

If I am not mistaken, only changing http://schema.org to https://schema.org. #296 solves the issue.

@alokpant
Copy link
Contributor

Rubocop is giving an warning.

+bundle exec rubocop -S -D
vendor/bundle/ruby/2.3.0/gems/jekyll-3.7.3/.rubocop.yml: Lint/EndAlignment has the wrong namespace - should be Layout
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in vendor/bundle/ruby/2.3.0/gems/jekyll-3.7.3/.rubocop.yml, please update it)

It is also failing in previous PRs, should I update Rubocop rules to use new rule syntax?

@DirtyF DirtyF closed this as completed May 23, 2018
@jekyll jekyll locked and limited conversation to collaborators May 23, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

3 participants