From 208ee028818c3d2d353176b7e3156276e98de915 Mon Sep 17 00:00:00 2001 From: Mikal Stordal Date: Sun, 17 Sep 2023 10:49:40 +0200 Subject: [PATCH 1/2] Add missing Collection Translations Found another thing missing I needed. While I haven't actually tested if I hooked it up correctly from within the library I have tested that the api accepts the 'translations' value in the 'append_to_response' query parameter and sends the translations with the other collection info. Example output from the api; ![image](https://github.com/revam/dotnet-tmdblib/assets/7761729/804b284b-aced-4b02-b3be-846046970b40) --- TMDbLib/Client/TMDbClientCollections.cs | 5 +++++ TMDbLib/Objects/Collections/Collection.cs | 3 +++ TMDbLib/Objects/Collections/CollectionMethods.cs | 4 +++- 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/TMDbLib/Client/TMDbClientCollections.cs b/TMDbLib/Client/TMDbClientCollections.cs index 87104527..148414e5 100644 --- a/TMDbLib/Client/TMDbClientCollections.cs +++ b/TMDbLib/Client/TMDbClientCollections.cs @@ -73,5 +73,10 @@ public async Task GetCollectionImagesAsync(int collectionId, strin { return await GetCollectionMethodInternal(collectionId, CollectionMethods.Images, language, cancellationToken).ConfigureAwait(false); } + + public async Task GetCollectionTranslationsAsync(int collecitonId, CancellationToken cancellationToken = default) + { + return await GetCollectionMethodInternal(collecitonId, CollectionMethods.Translations, null, cancellationToken).ConfigureAwait(false); + } } } \ No newline at end of file diff --git a/TMDbLib/Objects/Collections/Collection.cs b/TMDbLib/Objects/Collections/Collection.cs index 1ec3cce6..9f230e3c 100644 --- a/TMDbLib/Objects/Collections/Collection.cs +++ b/TMDbLib/Objects/Collections/Collection.cs @@ -16,6 +16,9 @@ public class Collection [JsonProperty("images")] public Images Images { get; set; } + [JsonProperty("translations")] + public TranslationsContainer Translations { get; set; } + [JsonProperty("name")] public string Name { get; set; } diff --git a/TMDbLib/Objects/Collections/CollectionMethods.cs b/TMDbLib/Objects/Collections/CollectionMethods.cs index f6f6c86d..a76777e1 100644 --- a/TMDbLib/Objects/Collections/CollectionMethods.cs +++ b/TMDbLib/Objects/Collections/CollectionMethods.cs @@ -9,6 +9,8 @@ public enum CollectionMethods [EnumValue("Undefined")] Undefined = 0, [EnumValue("images")] - Images = 1 + Images = 1, + [EnumValue("translations")] + Translations = 2, } } \ No newline at end of file From d750552b723aa1027af11a00b0b93f44bbf647c4 Mon Sep 17 00:00:00 2001 From: Mikal Stordal Date: Sun, 17 Sep 2023 12:51:13 +0200 Subject: [PATCH 2/2] =?UTF-8?q?fix=20typo=20=F0=9F=98=85?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- TMDbLib/Client/TMDbClientCollections.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/TMDbLib/Client/TMDbClientCollections.cs b/TMDbLib/Client/TMDbClientCollections.cs index 148414e5..269f0a6c 100644 --- a/TMDbLib/Client/TMDbClientCollections.cs +++ b/TMDbLib/Client/TMDbClientCollections.cs @@ -74,9 +74,9 @@ public async Task GetCollectionImagesAsync(int collectionId, strin return await GetCollectionMethodInternal(collectionId, CollectionMethods.Images, language, cancellationToken).ConfigureAwait(false); } - public async Task GetCollectionTranslationsAsync(int collecitonId, CancellationToken cancellationToken = default) + public async Task GetCollectionTranslationsAsync(int collectionId, CancellationToken cancellationToken = default) { - return await GetCollectionMethodInternal(collecitonId, CollectionMethods.Translations, null, cancellationToken).ConfigureAwait(false); + return await GetCollectionMethodInternal(collectionId, CollectionMethods.Translations, null, cancellationToken).ConfigureAwait(false); } } } \ No newline at end of file