Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replace docker-fixtures with testcontainers #857

Open
timja opened this issue Jul 8, 2022 · 4 comments
Open

Replace docker-fixtures with testcontainers #857

timja opened this issue Jul 8, 2022 · 4 comments

Comments

@timja
Copy link
Member

timja commented Jul 8, 2022

docker-fixtures has been deprecated for a long time, https://www.testcontainers.org is the recommended replacement.

We should switch to it.

@jtnord
Copy link
Member

jtnord commented Feb 21, 2023

there are issues with testcontainers - I would not recommend switching right away, or this PR should be inlined.

@olamy
Copy link
Member

olamy commented Mar 6, 2023

or upgrade to junit5 and simply use @Testcontainers(disabledWithoutDocker = true) ?

@jtnord
Copy link
Member

jtnord commented May 15, 2023

or upgrade to junit5 and simply use @Testcontainers(disabledWithoutDocker = true) ?

The issue with this (and the former PR) is that it will skip the entire test class/suite and not just the test that requires the docker container. (so a larger refactoring of tests would likely be needed, as we routinely mix containerized and non containerized in the same class). Additionally if you skip a class/suite then Jenkins won't know it is skipped in the Junit report so it won't mark the 5 tests in a class as skipped (it will if you skip at the test level).

Given we regressed docker support and no one noticed for quite some time - I would be hesitant of not recording tests as skipped so it stands out like Guliver in Lilliput

@jtnord
Copy link
Member

jtnord commented Sep 2, 2024

noting #1701 (comment)

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants