From b6ae940c7da56a1b87c74ab7fd6845e2a040e20a Mon Sep 17 00:00:00 2001 From: Mark Waite Date: Tue, 21 May 2024 12:09:53 -0600 Subject: [PATCH] Enable "Build has no changes" assertion in FreestyleJobTest Assertion was disabled due to user interface change that has been modified in Jenkins 2.459 to again report when the build has no changes. https://issues.jenkins.io/browse/JENKINS-73168 fixes it in Jenkins 2.459. https://github.com/jenkinsci/acceptance-test-harness/issues/1548 is the issue to remove the workaround. Revert part of "Work around JENKINS-73034 (#1547)" Tested by running the modified test with JENKINS_WAR set to a copy of the 2.459 Jenkins war file. This reverts part of commit 4d71d1b782a23b8eb94b914bf86771f212f3b7ed. --- src/test/java/core/FreestyleJobTest.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/test/java/core/FreestyleJobTest.java b/src/test/java/core/FreestyleJobTest.java index 4eb685b5d7..b22af46562 100644 --- a/src/test/java/core/FreestyleJobTest.java +++ b/src/test/java/core/FreestyleJobTest.java @@ -100,8 +100,7 @@ public void should_visit_build_with_permalink() { b.open(); assertThat("Permalink link is current URL", driver.getCurrentUrl(), is(expectedUrl)); assertThat("Build number is correct", b.getNumber(), is(1)); - // TODO JENKINS-73168 - //assertThat("Build has no changes", driver, hasContent("No changes")); + assertThat("Build has no changes", driver, hasContent("No changes")); assertThat("Build is success", b.getResult(), is(Build.Result.SUCCESS.name())); }