Added in ability for user to redefine update center plugin URL #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…releasing us from jenkins update center dependency)
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
@carlpulley are you able to write some tests around this parameter? Other than that, LGTM. Looks like #130 also includes changes for this, but in a slightly different manner. |
|
I've started refactoring this a bit locally, will update with a new pull request when I have it. Basically adding tests and setting some default for the value in |
|
Moving this work into #190 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jenkins update centre can be unreliable with some plugin downloads. Hence we here add in the ability for a user to redefine the update centre plugin URL.