repos should be enabled if repo=true on RedHat

[level99]

The current repo definition causes issues at the least on the latest Amazon Linux AMI (a RedHat derivative) because repos appear to be disabled by default. It's probably best to be explicit here in any case.

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

[rtyler]

I assumed that this was the default with yumrepo, does it really not default to enabled o_O

[jlambert121]

With the current setting are you getting enabled=0 in the yum config or just no entry?

Looking through the yumrepo provider I believe there isn't a default so not setting the property in puppet will not set the property in the yum config. From my quick testing, it also appears that not having an enabled= line in the yum config defaults to enabled (but I didn't quickly find any documentation to back that up)

Based on this, I believe if enabled=0 has ever manually been set in the yum.conf it would remain, but removing the file and letting puppet recreate it would create it without an enabled line.

[level99]

Currently, there is no enabled line in the jenkins.repo that is created so it's getting yum defaults.
There is also no enabled default being set in /etc/yum.conf either.

So I did some digging.. and it appears a yum plugin installed called yum-s3 (https://github.com/NumberFour/yum-s3-plugin) causes yum's default behavior for repositories to be disabled. I found the bug and will rebase against upstream which appears to resolve this issue.

Even so, I still think it would be a good idea to set this to explicitly enabled. I'm sure there are cases where plugins/users/etc. have (purposefully or not) changed the default yum repo status to disabled.

[matthewbarr]

Anyone see a reason not to merge this? Assuming we can get travis to do the right thing...

[rtyler]

I'm trusting @matthewbarr saying this can be merged means that it's safe