add single quotes for credentials #374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also strip inital credentials for single quotes, for backward compatibility
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
| JENKINS_USERNAME="<%= @ui_user -%>" | ||
| JENKINS_PASSWORD="<%= @ui_pass -%>" | ||
| # credentials should be single quoted | ||
| JENKINS_USERNAME="'<%= @ui_user.gsub!(/^\'|\'?$/, '') -%>'" |
There was a problem hiding this comment.
This will raise an exception when @ui_user is nil (undef).
Why isn't JENKINS_USERNAME='<%= @ui_user -%>' sufficient to stop the shell from interpolating the string?
There was a problem hiding this comment.
Yes you are right - exception on undef is really bad.
This regexp supposed to remove quotes if user input is already using quoted value as a workaround. So we could prevent double quoting.
|
A possible alternative solution would be to use |
rtyler
pushed a commit
to rtyler/puppet-jenkins
that referenced
this pull request
Oct 11, 2015
…lave defaults References voxpupuli#374 Fixes voxpupuli#371
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also strip inital credentials for single quotes, for backward compatibility