Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix username quoting #395

Merged
merged 2 commits into from
Oct 11, 2015
Merged

Conversation

rtyler
Copy link

@rtyler rtyler commented Oct 11, 2015

No description provided.

iakovgan and others added 2 commits October 11, 2015 13:44
also strip inital credentials for single quotes, for backward compatibility
@rtyler rtyler added this to the 1.6.0 - Kato milestone Oct 11, 2015
@@ -99,6 +99,9 @@

$client_jar = "swarm-client-${version}-jar-with-dependencies.jar"
$client_url = "http://maven.jenkins-ci.org/content/repositories/releases/org/jenkins-ci/plugins/swarm-client/${version}/"
$quoted_ui_user = shellquote($ui_user)
$quoted_ui_pass = shellquote($ui_pass)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jhoblitt pushed a commit that referenced this pull request Oct 11, 2015
@jhoblitt jhoblitt merged commit de64f8e into voxpupuli:master Oct 11, 2015
@rtyler rtyler deleted the fix-username-quoting branch October 12, 2015 12:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants