Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

H2 database performance decreased with v6 #2861

Closed
aikebah opened this issue Oct 3, 2020 · 1 comment
Closed

H2 database performance decreased with v6 #2861

aikebah opened this issue Oct 3, 2020 · 1 comment
Labels
Milestone

Comments

@aikebah
Copy link
Collaborator

aikebah commented Oct 3, 2020

Describe the bug
As discussed on the maillist users observed a significant slow-down with Dependency Check v6.
I did some digging around and found a suspect that upon initial testing appears to be valid: e175308 removed (accidentally I suppose, given the effects) the cpeEntry index from the H2 database, slowing down getCPEs significantly due to full-table scans .

Version of dependency-check used
The problem occurs using version 6.0.2 of the maven plugin

Logs
Extracts from logs for DependencyCheck 6.0.3 snapshot without the index on Jim Sellers' repository (total runtime :
[INFO] Finished CPE Analyzer (4 seconds)
[INFO] Finished CPE Analyzer (2 seconds)
[INFO] Finished CPE Analyzer (2 seconds)
[INFO] Finished CPE Analyzer (2 seconds)
[INFO] Finished CPE Analyzer (2 seconds)
[INFO] Finished CPE Analyzer (2 seconds)
[INFO] Finished CPE Analyzer (2 seconds)
[INFO] Finished CPE Analyzer (2 seconds)
[INFO] Finished CPE Analyzer (2 seconds)
[INFO] Finished CPE Analyzer (2 seconds)
[INFO] Finished CPE Analyzer (2 seconds)
[INFO] Total time: 01:00 min

A total of 24 seconds reported as spent in the CPE Analyzer

Extracts from logs for DependencyCheck 6.0.3 snapshot with the index on Jim Sellers' repository:
[INFO] Finished CPE Analyzer (2 seconds)
[INFO] Finished CPE Analyzer (1 seconds)
[INFO] Finished CPE Analyzer (1 seconds)
[INFO] Finished CPE Analyzer (0 seconds)
[INFO] Finished CPE Analyzer (0 seconds)
[INFO] Finished CPE Analyzer (0 seconds)
[INFO] Finished CPE Analyzer (0 seconds)
[INFO] Finished CPE Analyzer (0 seconds)
[INFO] Finished CPE Analyzer (0 seconds)
[INFO] Finished CPE Analyzer (0 seconds)
[INFO] Finished CPE Analyzer (0 seconds)
[INFO] Total time: 42.489 s

A total of 4 seconds reported as spent in the CPE Analyzer

To Reproduce
Steps to reproduce the behavior:

  1. Clone Jim Sellers' repository
  2. Run his script
  3. Observe the significant difference in total run time

Expected behavior
Only minor differences in speed due to new datamodel

Additional context
PR to restore the index will follow after I've locally validated that all tests properly pass

@jeremylong
Copy link
Owner

Thank you for investigating this - and the PR! This will be in the 6.0.3 release - I'm just trying to cleanup the FP reports before publishing so probably next weekend....

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants