Skip to content

Make multi-remote push behave the same way as opening pull requests #4292

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
ChrisMcD1 opened this issue Feb 20, 2025 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@ChrisMcD1
Copy link
Contributor

Is your feature request related to a problem? Please describe.
With the merging of #1889, we now have a very nice flow for choosing target branches for remotes. I would like to have the equivalent flow when pushing my branch up to a remote. Currently I have to press my arrow keys to go to the start of the line and erase the default remote and put in my new one.

Describe the solution you'd like
My ideal solution behaves the same way as opening a pull request with multiple remotes. If you have one remote, the suggestions will just show an auto-populated branch name. If you have multiple, then it will show you your remotes, with the default selected. After you pick your target remote, it will show you your default branch name filled out

Describe alternatives you've considered
Only alternative I can think of is doing no changes.

Additional context
I plan to implement this!

This would add an additional keystroke in the happy path case where you have 2 remotes and all the defaults are correct. You would have to press Confirm twice. Since this was deemed an acceptable trade-off for the opening of a pull request, I think it should be acceptable here too.

@ChrisMcD1 ChrisMcD1 added the enhancement New feature or request label Feb 20, 2025
@ChrisMcD1
Copy link
Contributor Author

Just realized that we don't actually currently set origin as the default remote when you open a pull request while having multiple remotes. Maybe we wouldn't want that behavior here either? It would add 1 keystroke to the happy path (tab into the remote selection before hitting enter), but allows you to continue to search the list if you have multiple.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant