fix(valid-describe): allow concise body arrow function (#106)

jest-community · May 23, 2018 · 4586bdc · 4586bdc
1 parent 8213ada
commit 4586bdc
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 8 deletions.
diff --git a/rules/__tests__/valid-describe.test.js b/rules/__tests__/valid-describe.test.js
@@ -34,6 +34,11 @@ ruleTester.run('valid-describe', rule, {
       })
     })
     `,
+    `
+    describe('foo', () =>
+      test('bar', () => {})
+    )
+    `,
   ],
   invalid: [
     {

diff --git a/rules/valid-describe.js b/rules/valid-describe.js
@@ -76,14 +76,16 @@ module.exports = {
               loc: paramsLocation(callbackFunction.params),
             });
           }
-          callbackFunction.body.body.forEach(node => {
-            if (node.type === 'ReturnStatement') {
-              context.report({
-                message: 'Unexpected return statement in describe callback',
-                node,
-              });
-            }
-          });
+          if (callbackFunction.body.type === 'BlockStatement') {
+            callbackFunction.body.body.forEach(node => {
+              if (node.type === 'ReturnStatement') {
+                context.report({
+                  message: 'Unexpected return statement in describe callback',
+                  node,
+                });
+              }
+            });
+          }
         }
       },
     };
-Original file line number
+Diff line change
@@ Expand Up / @@ -34,6 +34,11 @@ ruleTester.run('valid-describe', rule, { @@
           })
         })
         `,
+        `
+        describe('foo', () =>
+          test('bar', () => {})
+        )
+        `,
       ],
       invalid: [
         {
@@ Expand Down @@