fix(no-focused-tests): detect usage like 'test.only.each()'

jest-community · Oct 2, 2018 · 4e4313e · 4e4313e
1 parent 9ea1f78
commit 4e4313e
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 9 deletions.
diff --git a/rules/__tests__/no-focused-tests.test.js b/rules/__tests__/no-focused-tests.test.js
@@ -23,6 +23,10 @@ ruleTester.run('no-focused-tests', rule, {
       code: 'describe.only()',
       errors: [{ message: expectedErrorMessage, column: 10, line: 1 }],
     },
+    {
+      code: 'describe.only.each()',
+      errors: [{ message: expectedErrorMessage, column: 10, line: 1 }],
+    },
     {
       code: 'describe["only"]()',
       errors: [{ message: expectedErrorMessage, column: 10, line: 1 }],
@@ -31,6 +35,10 @@ ruleTester.run('no-focused-tests', rule, {
       code: 'it.only()',
       errors: [{ message: expectedErrorMessage, column: 4, line: 1 }],
     },
+    {
+      code: 'it.only.each()',
+      errors: [{ message: expectedErrorMessage, column: 4, line: 1 }],
+    },
     {
       code: 'it["only"]()',
       errors: [{ message: expectedErrorMessage, column: 4, line: 1 }],
@@ -39,6 +47,10 @@ ruleTester.run('no-focused-tests', rule, {
       code: 'test.only()',
       errors: [{ message: expectedErrorMessage, column: 6, line: 1 }],
     },
+    {
+      code: 'test.only.each()',
+      errors: [{ message: expectedErrorMessage, column: 6, line: 1 }],
+    },
     {
       code: 'test["only"]()',
       errors: [{ message: expectedErrorMessage, column: 6, line: 1 }],

diff --git a/rules/no-focused-tests.js b/rules/no-focused-tests.js
@@ -29,15 +29,25 @@ module.exports = {
     CallExpression(node) {
       const callee = node.callee;
 
-      if (
-        callee.type === 'MemberExpression' &&
-        isCallToTestOnlyFunction(callee)
-      ) {
-        context.report({
-          message: 'Unexpected focused test.',
-          node: callee.property,
-        });
-        return;
+      if (callee.type === 'MemberExpression') {
+        if (
+          callee.object.type === 'MemberExpression' &&
+          isCallToTestOnlyFunction(callee.object)
+        ) {
+          context.report({
+            message: 'Unexpected focused test.',
+            node: callee.object.property,
+          });
+          return;
+        }
+
+        if (isCallToTestOnlyFunction(callee)) {
+          context.report({
+            message: 'Unexpected focused test.',
+            node: callee.property,
+          });
+          return;
+        }
       }
 
       if (callee.type === 'Identifier' && isCallToFocusedTestFunction(callee)) {